The following document contains the results of SpotBugs
SpotBugs Version is 3.1.10
Threshold is medium
Effort is max
Class | Bugs |
---|---|
info.mikethomas.fahweb.action.TeamAction | 1 |
info.mikethomas.fahweb.action.UpdateAction | 9 |
info.mikethomas.fahweb.action.UserAction | 2 |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class info.mikethomas.fahweb.action.TeamAction defines non-transient non-serializable instance field teamService | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in info.mikethomas.fahweb.action.UpdateAction.updateTeams(): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 74 | High |
Found reliance on default encoding in info.mikethomas.fahweb.action.UpdateAction.updateUsers(): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 100 | High |
Dereference of the result of readLine() without nullcheck in info.mikethomas.fahweb.action.UpdateAction.updateTeams() | STYLE | NP_DEREFERENCE_OF_READLINE_VALUE | 84 | Medium |
Dereference of the result of readLine() without nullcheck in info.mikethomas.fahweb.action.UpdateAction.updateTeams() | STYLE | NP_DEREFERENCE_OF_READLINE_VALUE | 83 | Medium |
Dereference of the result of readLine() without nullcheck in info.mikethomas.fahweb.action.UpdateAction.updateUsers() | STYLE | NP_DEREFERENCE_OF_READLINE_VALUE | 109 | Medium |
info.mikethomas.fahweb.action.UpdateAction.updateTeams() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 75 | Medium |
info.mikethomas.fahweb.action.UpdateAction.updateUsers() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 101 | Medium |
Class info.mikethomas.fahweb.action.UpdateAction defines non-transient non-serializable instance field teamService | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class info.mikethomas.fahweb.action.UpdateAction defines non-transient non-serializable instance field userService | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class info.mikethomas.fahweb.action.UserAction defines non-transient non-serializable instance field userList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class info.mikethomas.fahweb.action.UserAction defines non-transient non-serializable instance field userService | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |