The following document contains the results of Checkstyle 6.11.2 with sun_checks.xml ruleset.
Category | Rule | Violations | Severity |
---|---|---|---|
coding | HiddenField | 30 | Error |
MagicNumber | 5 | Error | |
design | DesignForExtension | 57 | Error |
VisibilityModifier | 2 | Error | |
javadoc | JavadocMethod | 3 | Error |
JavadocPackage | 4 | Error | |
JavadocStyle | 22 | Error | |
JavadocVariable | 25 | Error | |
misc | FinalParameters | 47 | Error |
regexp | RegexpSingleline
|
48 | Error |
sizes | LineLength | 12 | Error |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 9 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 11 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 16 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 17 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 9 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 11 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 16 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 17 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 9 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 11 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 16 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 17 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
Error | design | DesignForExtension | Method 'execute' is not designed for extension - needs to be abstract, final or empty. | 42 |
Error | design | DesignForExtension | Method 'getPageTitle' is not designed for extension - needs to be abstract, final or empty. | 54 |
Error | design | DesignForExtension | Method 'getPpd' is not designed for extension - needs to be abstract, final or empty. | 63 |
Error | design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 72 |
Error | design | DesignForExtension | Method 'getStatus' is not designed for extension - needs to be abstract, final or empty. | 81 |
Error | sizes | LineLength | Line is longer than 80 characters (found 91). | 83 |
Error | design | DesignForExtension | Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 91 |
Error | design | DesignForExtension | Method 'getEta' is not designed for extension - needs to be abstract, final or empty. | 100 |
Error | design | DesignForExtension | Method 'getCredit' is not designed for extension - needs to be abstract, final or empty. | 109 |
Error | design | DesignForExtension | Method 'getPrcg' is not designed for extension - needs to be abstract, final or empty. | 118 |
Error | sizes | LineLength | Line is longer than 80 characters (found 110). | 119 |
Error | design | DesignForExtension | Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. | 127 |
Error | design | DesignForExtension | Method 'getControl' is not designed for extension - needs to be abstract, final or empty. | 136 |
Error | design | DesignForExtension | Method 'setControl' is not designed for extension - needs to be abstract, final or empty. | 145 |
Error | misc | FinalParameters | Parameter control should be final. | 145 |
Error | coding | HiddenField | 'control' hides a field. | 145 |
Error | design | DesignForExtension | Method 'setConnection' is not designed for extension - needs to be abstract, final or empty. | 149 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 149 |
Error | misc | FinalParameters | Parameter connection should be final. | 149 |
Error | coding | HiddenField | 'connection' hides a field. | 149 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 35 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
Error | design | DesignForExtension | Method 'getPageTitle' is not designed for extension - needs to be abstract, final or empty. | 46 |
Error | design | DesignForExtension | Method 'setPageTitle' is not designed for extension - needs to be abstract, final or empty. | 55 |
Error | misc | FinalParameters | Parameter pageTitle should be final. | 55 |
Error | coding | HiddenField | 'pageTitle' hides a field. | 55 |
Error | design | DesignForExtension | Method 'getPage' is not designed for extension - needs to be abstract, final or empty. | 64 |
Error | design | DesignForExtension | Method 'setPage' is not designed for extension - needs to be abstract, final or empty. | 73 |
Error | misc | FinalParameters | Parameter page should be final. | 73 |
Error | coding | HiddenField | 'page' hides a field. | 73 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocPackage | Missing package-info.java file. | |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 43 |
Error | misc | FinalParameters | Parameter teamService should be final. | 45 |
Error | coding | HiddenField | 'teamService' hides a field. | 45 |
Error | design | DesignForExtension | Method 'execute' is not designed for extension - needs to be abstract, final or empty. | 50 |
Error | design | DesignForExtension | Method 'getTeamList' is not designed for extension - needs to be abstract, final or empty. | 67 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 9 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 11 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 16 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 17 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 42 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 50 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 51 |
Error | misc | FinalParameters | Parameter teamService should be final. | 53 |
Error | coding | HiddenField | 'teamService' hides a field. | 53 |
Error | misc | FinalParameters | Parameter userService should be final. | 53 |
Error | coding | HiddenField | 'userService' hides a field. | 53 |
Error | design | DesignForExtension | Method 'execute' is not designed for extension - needs to be abstract, final or empty. | 59 |
Error | design | DesignForExtension | Method 'updateTeams' is not designed for extension - needs to be abstract, final or empty. | 72 |
Error | sizes | LineLength | Line is longer than 80 characters (found 88). | 73 |
Error | coding | MagicNumber | '4' is a magic number. | 83 |
Error | design | DesignForExtension | Method 'updateUsers' is not designed for extension - needs to be abstract, final or empty. | 98 |
Error | sizes | LineLength | Line is longer than 80 characters (found 88). | 99 |
Error | coding | MagicNumber | '4' is a magic number. | 109 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 119 |
Error | misc | FinalParameters | Parameter line should be final. | 119 |
Error | coding | MagicNumber | '3' is a magic number. | 125 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 130 |
Error | misc | FinalParameters | Parameter line should be final. | 130 |
Error | coding | MagicNumber | '3' is a magic number. | 136 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
Error | sizes | LineLength | Line is longer than 80 characters (found 86). | 43 |
Error | misc | FinalParameters | Parameter userService should be final. | 45 |
Error | coding | HiddenField | 'userService' hides a field. | 45 |
Error | design | DesignForExtension | Method 'execute' is not designed for extension - needs to be abstract, final or empty. | 50 |
Error | design | DesignForExtension | Method 'getUserList' is not designed for extension - needs to be abstract, final or empty. | 67 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 9 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 11 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 16 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 17 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
Error | design | DesignForExtension | Method 'setSessionFactory' is not designed for extension - needs to be abstract, final or empty. | 48 |
Error | misc | FinalParameters | Parameter sessionFactory should be final. | 48 |
Error | coding | HiddenField | 'sessionFactory' hides a field. | 48 |
Error | design | DesignForExtension | Method 'addTeam' is not designed for extension - needs to be abstract, final or empty. | 57 |
Error | misc | FinalParameters | Parameter team should be final. | 58 |
Error | design | DesignForExtension | Method 'listTeam' is not designed for extension - needs to be abstract, final or empty. | 69 |
Error | misc | FinalParameters | Parameter firstResult should be final. | 70 |
Error | misc | FinalParameters | Parameter maxResults should be final. | 70 |
Error | sizes | LineLength | Line is longer than 80 characters (found 102). | 71 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocPackage | Missing package-info.java file. | |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
Error | design | DesignForExtension | Method 'setSessionFactory' is not designed for extension - needs to be abstract, final or empty. | 48 |
Error | misc | FinalParameters | Parameter sessionFactory should be final. | 48 |
Error | coding | HiddenField | 'sessionFactory' hides a field. | 48 |
Error | design | DesignForExtension | Method 'addUser' is not designed for extension - needs to be abstract, final or empty. | 57 |
Error | misc | FinalParameters | Parameter user should be final. | 58 |
Error | design | DesignForExtension | Method 'listUser' is not designed for extension - needs to be abstract, final or empty. | 69 |
Error | misc | FinalParameters | Parameter firstResult should be final. | 70 |
Error | misc | FinalParameters | Parameter maxResults should be final. | 70 |
Error | sizes | LineLength | Line is longer than 80 characters (found 106). | 71 |
Error | design | DesignForExtension | Method 'listUserForTeam' is not designed for extension - needs to be abstract, final or empty. | 85 |
Error | sizes | LineLength | Line is longer than 80 characters (found 82). | 86 |
Error | misc | FinalParameters | Parameter team should be final. | 86 |
Error | misc | FinalParameters | Parameter firstResult should be final. | 86 |
Error | misc | FinalParameters | Parameter maxResults should be final. | 86 |
Error | sizes | LineLength | Line is longer than 80 characters (found 123). | 87 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocPackage | Missing package-info.java file. | |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
Error | misc | FinalParameters | Parameter team should be final. | 56 |
Error | coding | HiddenField | 'team' hides a field. | 56 |
Error | misc | FinalParameters | Parameter teamName should be final. | 56 |
Error | coding | HiddenField | 'teamName' hides a field. | 56 |
Error | misc | FinalParameters | Parameter score should be final. | 56 |
Error | coding | HiddenField | 'score' hides a field. | 56 |
Error | misc | FinalParameters | Parameter wu should be final. | 56 |
Error | coding | HiddenField | 'wu' hides a field. | 56 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 63 |
Error | design | DesignForExtension | Method 'getUniqueId' is not designed for extension - needs to be abstract, final or empty. | 68 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 72 |
Error | design | DesignForExtension | Method 'setUniqueId' is not designed for extension - needs to be abstract, final or empty. | 77 |
Error | misc | FinalParameters | Parameter uniqueId should be final. | 77 |
Error | coding | HiddenField | 'uniqueId' hides a field. | 77 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 81 |
Error | design | DesignForExtension | Method 'getTeam' is not designed for extension - needs to be abstract, final or empty. | 86 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 90 |
Error | design | DesignForExtension | Method 'setTeam' is not designed for extension - needs to be abstract, final or empty. | 95 |
Error | misc | FinalParameters | Parameter team should be final. | 95 |
Error | coding | HiddenField | 'team' hides a field. | 95 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 99 |
Error | design | DesignForExtension | Method 'getTeamName' is not designed for extension - needs to be abstract, final or empty. | 104 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 108 |
Error | design | DesignForExtension | Method 'setTeamName' is not designed for extension - needs to be abstract, final or empty. | 113 |
Error | misc | FinalParameters | Parameter teamName should be final. | 113 |
Error | coding | HiddenField | 'teamName' hides a field. | 113 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 117 |
Error | design | DesignForExtension | Method 'getScore' is not designed for extension - needs to be abstract, final or empty. | 122 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 126 |
Error | design | DesignForExtension | Method 'setScore' is not designed for extension - needs to be abstract, final or empty. | 131 |
Error | misc | FinalParameters | Parameter score should be final. | 131 |
Error | coding | HiddenField | 'score' hides a field. | 131 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 135 |
Error | design | DesignForExtension | Method 'getWu' is not designed for extension - needs to be abstract, final or empty. | 140 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 144 |
Error | design | DesignForExtension | Method 'setWu' is not designed for extension - needs to be abstract, final or empty. | 149 |
Error | misc | FinalParameters | Parameter wu should be final. | 149 |
Error | coding | HiddenField | 'wu' hides a field. | 149 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
Error | misc | FinalParameters | Parameter name should be final. | 54 |
Error | coding | HiddenField | 'name' hides a field. | 54 |
Error | misc | FinalParameters | Parameter newCredit should be final. | 54 |
Error | coding | HiddenField | 'newCredit' hides a field. | 54 |
Error | misc | FinalParameters | Parameter sum should be final. | 54 |
Error | coding | HiddenField | 'sum' hides a field. | 54 |
Error | misc | FinalParameters | Parameter team should be final. | 54 |
Error | coding | HiddenField | 'team' hides a field. | 54 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 61 |
Error | design | DesignForExtension | Method 'getUniqueId' is not designed for extension - needs to be abstract, final or empty. | 66 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 70 |
Error | design | DesignForExtension | Method 'setUniqueId' is not designed for extension - needs to be abstract, final or empty. | 75 |
Error | misc | FinalParameters | Parameter uniqueId should be final. | 75 |
Error | coding | HiddenField | 'uniqueId' hides a field. | 75 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 79 |
Error | design | DesignForExtension | Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 84 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 88 |
Error | design | DesignForExtension | Method 'setName' is not designed for extension - needs to be abstract, final or empty. | 93 |
Error | misc | FinalParameters | Parameter name should be final. | 93 |
Error | coding | HiddenField | 'name' hides a field. | 93 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 97 |
Error | design | DesignForExtension | Method 'getNewCredit' is not designed for extension - needs to be abstract, final or empty. | 102 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 106 |
Error | design | DesignForExtension | Method 'setNewCredit' is not designed for extension - needs to be abstract, final or empty. | 111 |
Error | misc | FinalParameters | Parameter newCredit should be final. | 111 |
Error | coding | HiddenField | 'newCredit' hides a field. | 111 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 115 |
Error | design | DesignForExtension | Method 'getSum' is not designed for extension - needs to be abstract, final or empty. | 120 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 124 |
Error | design | DesignForExtension | Method 'setSum' is not designed for extension - needs to be abstract, final or empty. | 129 |
Error | misc | FinalParameters | Parameter sum should be final. | 129 |
Error | coding | HiddenField | 'sum' hides a field. | 129 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 133 |
Error | design | DesignForExtension | Method 'getTeam' is not designed for extension - needs to be abstract, final or empty. | 138 |
Error | javadoc | JavadocStyle | First sentence should end with a period. | 142 |
Error | design | DesignForExtension | Method 'setTeam' is not designed for extension - needs to be abstract, final or empty. | 147 |
Error | misc | FinalParameters | Parameter team should be final. | 147 |
Error | coding | HiddenField | 'team' hides a field. | 147 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 9 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 11 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 16 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 17 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
Error | design | VisibilityModifier | Variable 'teamDao' must be private and have accessor methods. | 37 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 38 |
Error | design | DesignForExtension | Method 'setTeamDao' is not designed for extension - needs to be abstract, final or empty. | 44 |
Error | misc | FinalParameters | Parameter teamDao should be final. | 44 |
Error | coding | HiddenField | 'teamDao' hides a field. | 44 |
Error | design | DesignForExtension | Method 'addTeam' is not designed for extension - needs to be abstract, final or empty. | 53 |
Error | misc | FinalParameters | Parameter team should be final. | 53 |
Error | design | DesignForExtension | Method 'listTeam' is not designed for extension - needs to be abstract, final or empty. | 64 |
Error | misc | FinalParameters | Parameter firstResult should be final. | 64 |
Error | misc | FinalParameters | Parameter maxResults should be final. | 64 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocPackage | Missing package-info.java file. | |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 13 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 18 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
Error | design | VisibilityModifier | Variable 'userDao' must be private and have accessor methods. | 37 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 38 |
Error | design | DesignForExtension | Method 'setUserDao' is not designed for extension - needs to be abstract, final or empty. | 44 |
Error | misc | FinalParameters | Parameter userDao should be final. | 44 |
Error | coding | HiddenField | 'userDao' hides a field. | 44 |
Error | design | DesignForExtension | Method 'addUser' is not designed for extension - needs to be abstract, final or empty. | 53 |
Error | misc | FinalParameters | Parameter user should be final. | 53 |
Error | design | DesignForExtension | Method 'listUser' is not designed for extension - needs to be abstract, final or empty. | 64 |
Error | misc | FinalParameters | Parameter firstResult should be final. | 64 |
Error | misc | FinalParameters | Parameter maxResults should be final. | 64 |
Error | coding | MagicNumber | '39299' is a magic number. | 65 |